Add support for muted conversations #357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbrgn
added
app-update
Previously, the conversation was fetched and passed to `onNewMessage` before updating it with the new data. This could lead to situations like notifications being triggered for conversations that were muted since the last message, since the `isMuted` check would still operate on the old data. Additionally, the first message of a new conversation did previously not trigger a notification at all.
dbrgn
force-pushed
the
346-muted-notifications
branch
from
9bce0ec to
dd37435
Compare
sillych
approved these changes
Oct 18, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a conversation is muted, don't trigger notifications on new messages.
Additionally, indicate muted conversations in the conversation list:
For testing, current master of the app is required.
This PR also contains a bugfix for notifications not being triggered for new conversations.
Fixes #346.