Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

onDrawEnd called initially #84

Closed
thany opened this issue Jul 25, 2013 · 2 comments
Closed

onDrawEnd called initially #84

thany opened this issue Jul 25, 2013 · 2 comments

Comments

@thany
Copy link

thany commented Jul 25, 2013

The onDrawEnd callback is called initially, when the signaturepad is still empty. This makes it impossible to put some validation logic in this callback, because it will initially always be invalid (empty signature = invalid). It's not very friendly to display an error when the user hasn't done anything yet

Also, it's just not logical to call this callback initially when you look at the name. "onDrawEnd" indicates a segment has been drawn, but it hasn't. You can't have ended drawing a segment when nothing has been drawn.

So there you go. Two reason why this shouldn't happen in my opinion.

Signaturepad version I'm using: 2.4.0-1-g9c416df
Browser: Firefox 22 (although I don't think it's a browser issue)

@thomasjbradley
Copy link
Contributor

Yes, that's definitely a bug; I'll look into it.

@thomasjbradley
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants