Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config Version Downgrade is irrational #1769

Open
gbjk opened this issue Jan 8, 2025 · 0 comments · May be fixed by #1770
Open

Config Version Downgrade is irrational #1769

gbjk opened this issue Jan 8, 2025 · 0 comments · May be fixed by #1770
Assignees
Labels

Comments

@gbjk
Copy link
Collaborator

gbjk commented Jan 8, 2025

Originally posted by @gloriousCode in #1735 (comment)

TL;DR

Config Downgrade is an irrational mess

Problem

Downgrades are currently part of the usual upgrade path.
That's impossible. If the latest registered is less than the config version, there is no downgrade code available to run.
Additionally, downgrades need to stop before the target version.

Solution

  • Downgrades to a version need to be run on a branch that contains the existing current version
  • Downgrades should not be invoked automatically
  • Upgrade and Downgrade invoked from cmd/config should not use json marshalling, which will introduce stateful representation
  • Upgrading to a specific version can be supported, but we won't brag about it highlight it specifically as a feature
@gbjk gbjk self-assigned this Jan 8, 2025
@gbjk gbjk added the bug label Jan 8, 2025
@gbjk gbjk moved this to In progress in GoCryptoTrader Kanban Jan 8, 2025
gbjk added a commit to gbjk/gocryptotrader that referenced this issue Jan 9, 2025
gbjk added a commit to gbjk/gocryptotrader that referenced this issue Jan 9, 2025
gbjk added a commit to gbjk/gocryptotrader that referenced this issue Jan 9, 2025
@gbjk gbjk linked a pull request Jan 9, 2025 that will close this issue
3 tasks
gbjk added a commit to gbjk/gocryptotrader that referenced this issue Jan 9, 2025
gbjk added a commit to gbjk/gocryptotrader that referenced this issue Jan 10, 2025
gbjk added a commit to gbjk/gocryptotrader that referenced this issue Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: In progress
Development

Successfully merging a pull request may close this issue.

1 participant