Allow custom parameters to pytest.main

[stappersg]

Good stuff, thanks for your contribution. Now that the integration tests are working, a new test case covering this new endpoint will be ideal.

Originally posted by @raul-te in #18 (comment)

[stappersg]

Despite having

--- a/Makefile
+++ b/Makefile
@@ -19,8 +19,8 @@ shoelaces.8:
 docs: shoelaces.8
 
 test: fmt
-               $(GO) test -v $(pkgs) && \
-                       ./test/integ-test/integ_test.py
+               $(GO) test -vv $(pkgs) && \
+                       ./test/integ-test/integ_test.py -vv
 
 .PHONY: all clean docs
 

so -vv at two places, I keep getting

=============================================== FAILURES ================================================
________________________________ test_request_response[/start-start.txt] ________________________________

shoelaces_instance = <Popen: returncode: None args: ['/usr/src/github/shoelaces/shoelaces', '-con...>
request_path = '/start', response_file = 'start.txt'

    @pytest.mark.parametrize(("request_path", "response_file"), REQUEST_RESPONSE_PAIRS)
    def test_request_response(shoelaces_instance, request_path, response_file):
        with open(os.path.join(FIXTURE_DIR, response_file)) as response_body:
>           assert requests.get(
                API_URL + request_path).text == response_body.read()
E           AssertionError: assert '#!ipxe\necho...ll receive.\n' == '#!ipxe\necho...ll receive.\n'
E               #!ipxe
E               echo Shoelaces starts polling
E               chain --autofree --replace \
E                   http://localhost:18888/poll/1/${netX/mac:hexhyp}
E               #
E               #
E               # Do...
E             
E             ...Full output truncated (5 lines hidden), use '-vv' to show

/usr/src/github/shoelaces/test/integ-test/integ_test.py:116: AssertionError
----------------------------------------- Captured stdout call ------------------------------------------
ts=2023-01-08T17:49:37.517846401Z caller=server.go:2109 level=info component=http type=request src=127.0.0.1:57620 method=GET url=/start
======================================== short test summary info ========================================
FAILED test/integ-test/integ_test.py::test_request_response[/start-start.txt] - AssertionError: assert...
===================================== 1 failed, 34 passed in 0.35s ======================================

Repeating the

E             ...Full output truncated (5 lines hidden), use '-vv' to show

Where to add the -vv?

[stappersg]

The problem of "Where to add the -vv?" can been seen with either #22 or #23.

[raul-te]

The parameters to pytest.main are hardcoded:

if __name__ == "__main__":
    pytest.main(args=['-v'], plugins=None)

Ideally, would like to support custom parameters to have the flexibility of choosing either -v or -vv.

[stappersg]

Where to add the -vv?

The parameters to pytest.main are hardcoded:

if __name__ == "__main__":
    pytest.main(args=['-v'], plugins=None)

Ideally, would like to support custom parameters to have the flexibility of choosing either -v or -vv.

There is now #26.

[raul-te]

I think we will benefit if we add support for passing custom parameters to integ_test.py. Let me know if you're interested in implementing this feature.

We should leave the issue open until the feature reaches master.

[stappersg]

On Tue, Jan 17, 2023 at 10:53:01AM -0800, Raul Benencia wrote: Let me know if you're interested in implementing this feature.

Frankly: No

[stappersg]

I did not create this issue with subject "Allow custom parameters to pytest.main"
and I don't like the opened by me in the overview.

So now another close attempt.