Use I18n for month select #40
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Lovely, thank you. |
|
Can you add a spec for this method using a different locale? |
|
Sure, give me a sec |
|
ready 👍 |
| expect(page.find('#user_date_of_birth_1i').value).to eq('1980') | ||
| expect(page.find('#user_date_of_birth_2i').value).to eq('1') | ||
| expect(page.find('#user_date_of_birth_3i').value).to eq('2') | ||
| I18n.locale = :en |
There was a problem hiding this comment.
Since expect will raise an error (in a failure case) and the RSpec runner will catch it, we need to ensure this global state is reset. My suggestion:
it '...' do
begin
I18n.locale = :es
# the rest of the spec
ensure
I18n.locale = :en
end
end
There was a problem hiding this comment.
great suggestion!
|
done 👍 |
|
bump |
calebhearth
added a commit
that referenced
this pull request
Feb 6, 2015
|
Merged in e4eb895 |
calebhearth
added a commit
that referenced
this pull request
Feb 6, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If your locale is not english it won't select months, this fixes it 👍