-
-
Notifications
You must be signed in to change notification settings - Fork 374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gemspec is missing required_ruby_version #456
Comments
+1 |
As factory_bot defines a required Ruby version and |
This gem includes Ruby code, though. It should have an opinion (and test matrix) on the Ruby versions with which its code is compatible. It doesn't matter if Factory Bot is compatible with Ruby 3.2 if Factory Bot Rails has code that is NOT compatible with Ruby 3.2, for example. The specs SHOULD diverge, in such a case. |
I disagree that there's any case they should diverge but I see no disadvantage of adding the minimal Ruby version as with |
Closely related to thoughtbot/factory_bot#1614: the gemspec doesn't claim any specific Ruby compatibility, but it's pretty clear from commits like 499635f that only specific ones are supported. The gem will be far easier to use if the gemspec can make that clear.
The text was updated successfully, but these errors were encountered: