Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gemspec is missing required_ruby_version #456

Closed
kyrofa opened this issue Jan 2, 2024 · 4 comments · Fixed by #510
Closed

gemspec is missing required_ruby_version #456

kyrofa opened this issue Jan 2, 2024 · 4 comments · Fixed by #510
Labels

Comments

@kyrofa
Copy link

kyrofa commented Jan 2, 2024

Closely related to thoughtbot/factory_bot#1614: the gemspec doesn't claim any specific Ruby compatibility, but it's pretty clear from commits like 499635f that only specific ones are supported. The gem will be far easier to use if the gemspec can make that clear.

@kyrofa kyrofa added the bug label Jan 2, 2024
@JuanVqz
Copy link

JuanVqz commented Jul 4, 2024

+1

@unused
Copy link
Contributor

unused commented Oct 25, 2024

As factory_bot defines a required Ruby version and factory_bot_rails has a clear dependency on it, there is no need to keep it redundant with it's own Gemspec. Avoiding this also ensures the specifications can't diverge.

@kyrofa
Copy link
Author

kyrofa commented Oct 25, 2024

This gem includes Ruby code, though. It should have an opinion (and test matrix) on the Ruby versions with which its code is compatible. It doesn't matter if Factory Bot is compatible with Ruby 3.2 if Factory Bot Rails has code that is NOT compatible with Ruby 3.2, for example. The specs SHOULD diverge, in such a case.

@unused
Copy link
Contributor

unused commented Oct 28, 2024

I disagree that there's any case they should diverge but I see no disadvantage of adding the minimal Ruby version as with factory_bot to the specification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants