Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub provider whitelist with username? #256

Closed
Poeschl opened this issue May 27, 2021 · 1 comment
Closed

GitHub provider whitelist with username? #256

Poeschl opened this issue May 27, 2021 · 1 comment

Comments

@Poeschl
Copy link

Poeschl commented May 27, 2021

Would it be possible to fallback to the username in case of the GitHub OAuth? With that users could als be whitelisted and filtered by rules.

I understand that its a custom setting just for GitHub but maybe it can be also a setting for the oauth provider.
For example --providers.generic-oauth.user-field=login to specify the login attribute of the User Url endpoint.

@thomseddon
Copy link
Owner

I think #159 would work for you?

Please re-open if not

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants