-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for Lighthouse #348
Comments
You can get the port by getting the browser from the page and then the port from the browser as demonstrated here:
The problem I'm finding is that when Lighthouse takes over the Puppeteer instance it kills the puppeteer-cluster task before it has completed. This results in Lighthouse not being able to find the browser. EDIT |
Yeah, the integration looked quiet cumbersome. So I just created two files:
|
Hi @jasonreiche & @kushalhalder Could you please describe in more detail how were you able to access wsEndpoint simultaneously running Puppeteer Cluster (not a single instance)? I tried both of your examples but I without any success. |
@kacbrz, I was not able to get multiple instances of Lighthouse to run concurrently using puppeteer-cluster. Lighthouse is not designed to run concurrently as that would skew performance results. Lighthouse conflicts with itself if multiple instances are running in the same Node process. You could look at using lighthouse-batch-parallel. When I need to run Lighthouse, I just use puppeteer-cluster to manage the pool and run a concurrency of 1. In my case, I'm just looking for accessibility scores so we are switching over to axe-core moving forward. |
@jasonreiche Thank you for replying! Last couple of days I was thinking about the performance in the exact same context you've provided. Despite that I still have to build a cluster of Lighthouses and somehow handle the performance issue. My small project just evolved and got a little bit more difficult... |
Hi @kacbrz, my use case was different. I did not have a cluster, and I also had only one machine. What I wanted was that I launch a chrome instance, which exposes a port through which I can push lighthouse events which run in different tabs as separate sessions. The above snippets simulate this. |
Essentially, lighthouse needs the port at which the chrome instance is running to run a job on the tab. Is that possible here?
The text was updated successfully, but these errors were encountered: