Compute transform of hnf_with_transform
after the fact
#1108
+115
−26
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From my experience in #1102, it seemed to be worth wile, to compute the
S
inH = AS
by computing the hnfH
and then solvingH = AS
. At least for random square matrices this is much faster, than takingH, T = hnf_with_transform(A)
and invertingT
.Additionally, for random square matrices larger than 100×100, it even becomes faster to compute
T
viaS
.