Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set html content with editor setContent(), supports textarea #72

Merged
merged 2 commits into from
Oct 4, 2016
Merged

Set html content with editor setContent(), supports textarea #72

merged 2 commits into from
Oct 4, 2016

Conversation

toddkittredge
Copy link
Contributor

Resolves issue... Textarea div not populated with ngModel.$viewValue when present #71

@thijsw
Copy link
Owner

thijsw commented Oct 4, 2016

Thanks for reporting this issue, and providing a fix as well! Will merge straight away if minified version is included as well :)

@toddkittredge
Copy link
Contributor Author

Happy to help... "if minified version is included", do you want a push to /dist or will you generate that on your end?

@thijsw
Copy link
Owner

thijsw commented Oct 4, 2016

After you've edited the files in src/ (which you already did), you can run grunt (without arguments) to generate the minified production-ready version of the library. :)

@toddkittredge
Copy link
Contributor Author

Already tested build here, will promote result to /dist !

@toddkittredge
Copy link
Contributor Author

Was confusing procedural comments in YABWE regarding pushing (or not as is the case) to /dist...

Good to go!

@thijsw thijsw merged commit 1e7b319 into thijsw:master Oct 4, 2016
@thijsw
Copy link
Owner

thijsw commented Oct 4, 2016

Nevermind. Thanks for your contribution!

@Twista Twista mentioned this pull request Jan 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants