Implement support for Rails 5.2 #488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… connections have been cleared
|
I have amended this PR with a fix for this issue which seems to be related to Rails 5.2 #489 It seems like a hacky fix and I do not know what implications it might have on running processes. So see it as a basis for discussion :) |
thiagopradi
changed the base branch from
master
to
feature/updating-octopus-versions
|
Hi @erkie - I'm merging your PR into the base branch for Rails 5.2 called |
bvicenzo
reviewed
Jan 21, 2019
| def self.atleast_rails51? | ||
| ActiveRecord::VERSION::MAJOR > 5 || (ActiveRecord::VERSION::MAJOR == 5 && ActiveRecord::VERSION::MINOR >= 1) | ||
| end | ||
|
|
||
| def self.atleast_rails52? | ||
| ActiveRecord::VERSION::MAJOR > 5 || (ActiveRecord::VERSION::MAJOR == 5 && ActiveRecord::VERSION::MINOR >= 1) |
There was a problem hiding this comment.
Guys, since the method name is atleast_rails52, shouldn't it be:
ActiveRecord::VERSION::MAJOR >= 5 && ActiveRecord::VERSION::MINOR >= 2
# or Fix ActiveRecord::VERSION::MINOR >= 1 to ActiveRecord::VERSION::MINOR >= 2
# because it's exactly the same as the `.atleast_rails51?` method is.The same question for the method . atleast_rails51?...
🤔
There was a problem hiding this comment.
@bvicenzo - you are right. I'll double check and fix this method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was what I needed to be almost 1 be able to run Octopus using Rails 5.2 that was released recently. This fork can probably(maybe?) be used by anyone wanting to start using Rails 5.2, until something more official comes along.
1 I say almost because it still crashes on #477 So to be able to start using this gem I created a separate branch in my fork where I just disabled migrations for now. Currently I don't need it. A lot had changed in the Rails classes and I know too little of what should go where... https://github.com/feederco/octopus/tree/rails-5.2-disabled-migrations