Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datetimepicker bug? #751

Closed
pedrosino opened this issue Jun 29, 2016 · 12 comments
Closed

Datetimepicker bug? #751

pedrosino opened this issue Jun 29, 2016 · 12 comments
Assignees
Labels
TYPE: bug Bug reported by a stakeholder

Comments

@pedrosino
Copy link
Contributor

While editing a competition yesterday, I found that selecting October 15th 2016 is very messy. See gif below.
Basically the field is saved as 2016-10-16 on the database, but for some reason it appear as 2016-10-15 on the input. Also, when the datetimepicker opens, there are two (?!) day 15, one being to the right of everything else.

I'm able to click on the 16th and save, but on reloading the problem repeats.

Could this be something local? Can anybody try to replicate this?
out

@larspetrus
Copy link
Contributor

It's probably some broken assumptions about time zones in the code.

Can you try it at different times of day and see if it acts differently?

@pedrosino
Copy link
Contributor Author

Just tried again and got the same result.
I remember seeing this a couple weeks ago too, in another project of mine.

@jfly jfly added the TYPE: bug Bug reported by a stakeholder label Sep 13, 2016
@pedrosino
Copy link
Contributor Author

pedrosino commented Sep 16, 2016

I was fixing a birthdate today and realised it also fails for october 1991:
october

@pedrosino
Copy link
Contributor Author

For the record, I just created zpaulovics/datetimepicker-rails#83

@pedrosino
Copy link
Contributor Author

zpaulovics/datetimepicker-rails#83 (comment)
Seems like there is hope :D

@ronaldmansveld
Copy link
Contributor

@pedrosino

Are we still using that same library for the datepicker? Does the issue still exist? I see their last commit was in 2015, so that doesn't give much hope ;)

If we have moved to a different datepicker, then please close this ticket.

@pedrosino
Copy link
Contributor Author

Yeah, it does:
image

@ronaldmansveld
Copy link
Contributor

In that case we should move to a different datepicker, one that is still under active maintenance ;)

@UnsolvedCypher
Copy link
Contributor

@pedrosino Could you check whether this branch still has the same issue?

@pedrosino
Copy link
Contributor Author

@UnsolvedCypher Sorry for the delaty
It works fine with your branch, but also seems to work on the WCA website now:
Peek 28-02-2020 21-54

@UnsolvedCypher
Copy link
Contributor

Oh that's good to hear! In that case I guess this issue can be closed

@viroulep
Copy link
Contributor

Love these kind of issues :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TYPE: bug Bug reported by a stakeholder
Projects
None yet
Development

No branches or pull requests

6 participants