Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't give organizers manager/scoretaker access by default #138

Open
JonEsparaz opened this issue Jan 21, 2023 · 1 comment
Open

Don't give organizers manager/scoretaker access by default #138

JonEsparaz opened this issue Jan 21, 2023 · 1 comment

Comments

@JonEsparaz
Copy link
Contributor

JonEsparaz commented Jan 21, 2023

Principle of least privilege :)

IMO, and as mentioned in thewca/worldcubeassociation.org#7168 (comment), organizers should not have manager/scoretaker access by default. I think only delegates need manager access (to add/remove scoretakers), then they can add other users (including organizers) as scoretakers as needed (or give out one-time codes).

Relevant code here:

"organizer" in staff_member.roles

I'm happy to make this PR if there's no resistance from the WST or a majority of Delegates regarding application hehaviour.

@jonatanklosko
Copy link
Member

I don't have a strong opinion on the decision specifically, but I'm not certain that changing the behaviour of WCA Live alone is the way to go.

The WCA website treats organizers as "competition managers", the implication is that they have permission to update WCIF anyway. For instance, they can modify the competition with a tool such as Groupifier, which I think is essential. Similarly, an organizer can import a competition, because when we ask the WCA API for manageable competitions of the given user, it would return competitions where the person is an organizer; we could surely then filter only those where the person is actually a delegate, but this is just another indicator that we are only seemingly limiting the access.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants