Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ngtests: Add tests for delegated roles metadata update #1641

Closed
sechkova opened this issue Oct 27, 2021 · 1 comment · Fixed by #1711
Closed

ngtests: Add tests for delegated roles metadata update #1641

sechkova opened this issue Oct 27, 2021 · 1 comment · Fixed by #1711
Assignees
Labels
backlog Issues to address with priority for current development goals testing
Milestone

Comments

@sechkova
Copy link
Contributor

Description of issue or feature request:

Add tests for updating delegated roles metadata following 5.6.7 from the specification. A preliminary list of expected test cases:

  • Successful update finds target's metadata
  • Successful update does not find target's metadata
  • Not loading targets metadata twice when looking for a target file
  • TargetInfo is what was expected
  • Visited max number of roles
  • Terminating delegations

The tests should:

  • Use RepositorySimulator for serving test files in-memory.
  • "black-box" Updater, don't look at its internals, check if files are downloaded as expected (or not downloaded as expected).
@sechkova sechkova added testing backlog Issues to address with priority for current development goals labels Oct 27, 2021
@sechkova sechkova self-assigned this Nov 10, 2021
@sechkova sechkova added this to the Sprint 12 milestone Nov 10, 2021
@jku
Copy link
Member

jku commented Nov 15, 2021

Leaving a note here: once #1654 merges, let's mostly use the implicit refresh in this tests: it makes the code one line shorter and makes sure everything gets tested (as the explicit refresh is tested plenty in test_updater_top_level_update.py already)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog Issues to address with priority for current development goals testing
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants