Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allows parse_dotenv(stream=StringIO()) #78

Merged
merged 7 commits into from
Mar 3, 2018

Conversation

alanjds
Copy link
Contributor

@alanjds alanjds commented Dec 9, 2017

Backwards-compatible API for parse_dotenv() that allows a stream having a dotfile to be parsed.

The other option would be to save my already-existing stream in disk and providing the filepath, but this could have security and performance considerations.

@alanjds alanjds changed the title allows `parse_dotenv(stream=StringIO()) allows parse_dotenv(stream=StringIO()) Dec 9, 2017
@alanjds alanjds changed the title allows parse_dotenv(stream=StringIO()) Allows parse_dotenv(stream=StringIO()) Dec 9, 2017
@coveralls
Copy link

coveralls commented Dec 9, 2017

Coverage Status

Coverage decreased (-0.6%) to 84.653% when pulling ec6f70d on alanjds:parse_stream into ef2ee9d on theskumar:master.

@theskumar
Copy link
Owner

This looks good. parse_dotenv is not considered a public api as of yet, but I think it's high time we do so.

Some tests are failing due to installation flake8 issues on travis for python 3.4, that I'll fix up.

Would it be possible for you to add some test cases and related documentation as well, for this so others can followup and use this functionality.

@alanjds
Copy link
Contributor Author

alanjds commented Dec 21, 2017

Sure. But not "right now".

Probable after the new year I can get back to work in tests/docs.

Thanks for reviewing it.

@coveralls
Copy link

coveralls commented Jan 15, 2018

Coverage Status

Coverage increased (+0.4%) to 85.644% when pulling 6f2fb0b on alanjds:parse_stream into 6eb1698 on theskumar:master.

@coveralls
Copy link

coveralls commented Jan 15, 2018

Coverage Status

Coverage increased (+0.4%) to 85.644% when pulling 6c5c83a on alanjds:parse_stream into 6eb1698 on theskumar:master.

@alanjds
Copy link
Contributor Author

alanjds commented Jan 15, 2018

Docs and Tests included.

@coveralls
Copy link

coveralls commented Jan 15, 2018

Coverage Status

Coverage increased (+0.4%) to 85.644% when pulling 4283f12 on alanjds:parse_stream into 6eb1698 on theskumar:master.

@theskumar
Copy link
Owner

Thanks @alanjds, look great merging this in. Will update changelog in master and make a release. :)

Also i think, i'm going to update

from dotenv.main import parse_dotenv

with

from dotenv import parse_dotenv

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants