Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shared types between frontend and backend #40

Open
jhnj opened this issue Apr 15, 2020 · 1 comment · May be fixed by #47
Open

Shared types between frontend and backend #40

jhnj opened this issue Apr 15, 2020 · 1 comment · May be fixed by #47

Comments

@jhnj
Copy link
Collaborator

jhnj commented Apr 15, 2020 •
edited
Loading

When we move the backend to typescript it would be nice to have a shared API (ws, rest).

There are many different ways of implementing this, I would suggest having a separate package for types using yarn workspaces. Simple and doesn't require big changes
@jhnj jhnj mentioned this issue Apr 15, 2020
Merged
@thesauri
Copy link
Owner

thesauri commented Apr 15, 2020 •
edited
Loading

Status update: sharing is now possible as workspaces have been added, but the types themselves haven't been added yet.

@thesauri thesauri linked a pull request Apr 19, 2020 that will close this issue
WIP Typescriptify backend #47
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

WIP Typescriptify backend thesauri/korsord
2 participants
@thesauri @jhnj