Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkout gateway purchase request issues #216

Open
simonworkhouse opened this issue Mar 24, 2022 · 0 comments
Open

Checkout gateway purchase request issues #216

simonworkhouse opened this issue Mar 24, 2022 · 0 comments

Comments

@simonworkhouse
Copy link

It appears that the resulting response from an Omnipay\Stripe\Message\Checkout\PurchaseRequest request always returns true from the isSuccessful method; whereas I would have expected for it to respond with a specific redirect response and to always fall back to false for calls to isSuccessful.

Additionally, the completePurchase method hasn't been implemented and that would at least be one that I'd expect to see for a payment method like this. Perhaps the intent was to utilise the capture method instead?

There's also the issue of line items not being pre-filled from the ItemBag and other required parameters not having default values set.

I could submit a pull request for these updates (if I get time), but I'm just wanting to confirm whether or not this is actually the intended behaviour.

So is this the intended behaviour?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant