Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix preg_match search on NULL #179

Merged
merged 1 commit into from
Mar 8, 2022
Merged

Fix preg_match search on NULL #179

merged 1 commit into from
Mar 8, 2022

Conversation

jamieburchell
Copy link
Contributor

@judgej
Copy link
Member

judgej commented Mar 8, 2022 •
edited
Loading

Additional fixes are needed, and I'll add tests with them. The Sage Pay Server integration does not accept the clientIpAddress as a parameter (the Sage Pay Direct integration does), so this integration should not be referencing getClientIp() in the first place. The deprecation warning highlighted that it was referencing the client IP address.

Merging without tests as very clear what this fixes, but will add one with later commits.

@judgej judgej merged commit 2925574 into thephpleague:master Mar 8, 2022
@jamieburchell jamieburchell deleted the patch-1 branch September 18, 2023 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deprecated: preg_match() Passing null in getClientIp()
2 participants
@jamieburchell @judgej