Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove PHP 5.6 workaround/comments #176

Open
jamieburchell opened this issue Feb 23, 2022 · 0 comments
Open

Remove PHP 5.6 workaround/comments #176

jamieburchell opened this issue Feb 23, 2022 · 0 comments

Comments

@jamieburchell
Copy link
Contributor

@judgej

Looking at this diff there are comments about a PHP 5.6 specific workaround:

        // The Response in the current namespace conflicts with
        // the Response in the namespace one level down, but only
        // for PHP 5.6. This alias works around it.

Since the library now only supports PHP 7.3+, this should be reviewed for relevance. It's not clear if the comment is still relevant to the surrounding code and the changes that have been made to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant