Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(build): Add cypress for end-to-end (integration) testing #85

Merged
merged 6 commits into from
May 6, 2022

Conversation

tulup-conner
Copy link
Collaborator

@tulup-conner tulup-conner commented May 5, 2022

Breaking changes

None.

Features

  • cypress can now be used to create end-to-end (integration) tests in cypress/integration for pages in src/docs/pages (Resolves Cypress + Axe testing #35)
    • cypress-axe can also be used to check for easy a11y fixes

Bug fixes

None.

Tests

Integration

  • Add integration tests for Carousel docs page

@tulup-conner tulup-conner marked this pull request as ready for review May 5, 2022 06:37
@rluders
Copy link
Collaborator

rluders commented May 5, 2022

@tulup-conner can we make it part of the CI?

@rluders rluders self-requested a review May 5, 2022 14:19
cypress/integration/docs/pages/CarouselPage.spec.ts Outdated Show resolved Hide resolved
cypress/support/commands.ts Outdated Show resolved Hide resolved
@tulup-conner tulup-conner requested a review from rluders May 5, 2022 23:33
@tulup-conner
Copy link
Collaborator Author

tulup-conner commented May 6, 2022

@tulup-conner can we make it part of the CI?

I think we should but this won't currently work since there are several a11y issues on every Docs page. My thought is create another PR to resolve the outstanding site-wide a11y issues so the tests will pass. But, I can roll that into this if you like.

@rluders
Copy link
Collaborator

rluders commented May 6, 2022

@tulup-conner can we make it part of the CI?

I think we should but this won't currently work since there are several a11y issues on every Docs page. My thought is create another PR to resolve the outstanding site-wide a11y issues so the tests will pass. But, I can roll that into this if you like.

Yep, it makes sense. We can enable it once we have the issues solved.

@rluders rluders merged commit 4df13e6 into themesberg:main May 6, 2022
@tulup-conner tulup-conner deleted the feature/cypress-e2e-testing branch May 6, 2022 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cypress + Axe testing
2 participants