Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(component): fix Label component disabled property not applying theme styles #763

Merged
merged 1 commit into from
May 25, 2023

Conversation

jananxd
Copy link
Contributor

@jananxd jananxd commented May 25, 2023

fixes #762

Description

fix not applying disabled state styles on Label component and add a component test to make sure it doesn't get broken

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Breaking changes

None

How Has This Been Tested?

  • component test
  • manual check using the browser

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@codecov
Copy link

codecov bot commented May 25, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (1b07a76) 99.43% compared to head (71a7ddf) 99.43%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #763   +/-   ##
=======================================
  Coverage   99.43%   99.43%           
=======================================
  Files         131      131           
  Lines        6528     6529    +1     
  Branches      490      490           
=======================================
+ Hits         6491     6492    +1     
  Misses         37       37           
Impacted Files Coverage Δ
src/lib/components/Label/Label.tsx 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@rluders rluders merged commit 8d6d79e into themesberg:main May 25, 2023
rtraficante pushed a commit to rtraficante/flowbite-react that referenced this pull request May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Label component disabled property doesn't apply styles
2 participants