Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(modal): overflow bug fix #718

Merged
merged 1 commit into from
May 25, 2023
Merged

Conversation

paghar
Copy link
Contributor

@paghar paghar commented Apr 25, 2023

#537

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change contains documentation update

Breaking changes

Please document the breaking changes if suitable.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • Firmware version:
  • Hardware:
  • Toolchain:
  • SDK:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@paghar
Copy link
Contributor Author

paghar commented Apr 26, 2023

@rluders Please check my PR, The CL faced a strange error. It is not related to my branch.

@codecov
Copy link

codecov bot commented May 2, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.05 ⚠️

Comparison is base (8e8531b) 99.43% compared to head (e987906) 99.38%.

❗ Current head e987906 differs from pull request most recent head e6de01d. Consider uploading reports for the commit e6de01d to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #718      +/-   ##
==========================================
- Coverage   99.43%   99.38%   -0.05%     
==========================================
  Files         131      131              
  Lines        6559     6527      -32     
  Branches      493      489       -4     
==========================================
- Hits         6522     6487      -35     
- Misses         37       40       +3     
Impacted Files Coverage Δ
src/lib/theme/default.ts 100.00% <100.00%> (ø)

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@paghar
Copy link
Contributor Author

paghar commented May 2, 2023

@tulup-conner

@rluders rluders force-pushed the bug-fix-modal-overflow branch from e987906 to 627ec69 Compare May 25, 2023 14:27
@rluders rluders force-pushed the bug-fix-modal-overflow branch from 627ec69 to e6de01d Compare May 25, 2023 14:41
@rluders rluders merged commit 9e4e43a into themesberg:main May 25, 2023
rtraficante pushed a commit to rtraficante/flowbite-react that referenced this pull request May 26, 2023
@paghar paghar deleted the bug-fix-modal-overflow branch November 2, 2023 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants