feat(route): Add Sidebar examples page & stories, resolving #53 #56
#69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tulup-conner
force-pushed
the
feature/add-sidebar-page
branch
3 times, most recently
from
da905aa to
1e8209c
Compare
tulup-conner
added a commit
to tulup-conner/flowbite-react
that referenced
this pull request
May 1, 2022
`storybook` provides a `decorators` object to let us wrap components rendered in `storybook` with some HTML. This change wraps every component in a centered flex box which is a nicer UX than the top left. It also adds `MemoryRouter` which is required to merge themesberg#69.
tulup-conner
changed the title
Sidebar examples pageSidebar examples page & stories
tulup-conner
changed the title
Sidebar examples page & storiesSidebar examples page & stories, resolving #53 #56
tulup-conner
force-pushed
the
feature/add-sidebar-page
branch
from
1cb513b to
cfaa041
Compare
|
This branch is up to date now and ready to merge instantly. I didn't consider this consequence of tying it to the other PR, sorry about that. |
bacali95
reviewed
May 2, 2022
rluders
pushed a commit
that referenced
this pull request
May 2, 2022
* chore(deps): Remove `@popperjs/core` * chore(deps): Install `@floating-ui/react-*` These packages replaces `@popperjs/*`. * refactor(component): Upgrade `Tooltip` to `@floating-ui/react-*` Replaces `@popperjs/*`. refactor(component): Re-enable `Tooltip` trigger either `click` or `hover` refactor(component): Re-enable `Tooltip` arrow refactor(component): Re-enable Tooltip auto placement refactor(component): Re-enable `Tooltip` transitions fix(component): Undo effect requiring arrow in `Tooltip` `Tooltip`s should be able to be created without using the arrow. fix(component): Overlap `Tooltip` arrow with text via `z-index` Prevents the text inside a `Tooltip` from being obscured by the `Tooltip` arrow. fix(component): Resolve `Tooltip` arrow placement when `placement` = `auto` Retrieves the actual placement calculated by `floating-ui` from the hook. This is crucial when the component is created with `auto` placement. * fix(component): Resolve #57 Inside `storybook`, `Tooltip`s were misaligned from the parent element on `Chromium` browsers. * refactor(component): Replace simple `if/else` by ternary * refactor(story): Update `storybook` wrapper `storybook` provides a `decorators` object to let us wrap components rendered in `storybook` with some HTML. This change wraps every component in a centered flex box which is a nicer UX than the top left. It also adds `MemoryRouter` which is required to merge #69.
Adds the following examples for `Sidebar`s: - [x] Default sidebar - [x] Multi-level dropdown - [x] Content separator - [x] CTA button - [x] Logo branding
The `Sidebar` is not highly configurable at the root component, but there are a number of ways to set up the contents, so we added those examples.
Creating a component to reuse the code between `storybook` and the page caused the page to display the shortcut component instead of the actual component's code.
tulup-conner
force-pushed
the
feature/add-sidebar-page
branch
2 times, most recently
from
880b29a to
d96fe4e
Compare
tulup-conner
force-pushed
the
feature/add-sidebar-page
branch
from
d96fe4e to
96e9805
Compare
bacali95
approved these changes
May 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the following examples for
Sidebars:The following can't be finished yet, because thecomponent needs work:
Once #72 is accepted I can finalize this PR.
This resolves #53.
Also adds Storybook stories for Sidebar, resolving #56.