fix: group list styling #668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #668 +/- ##
=======================================
Coverage 99.42% 99.42%
=======================================
Files 130 130
Lines 6450 6450
Branches 485 485
=======================================
Hits 6413 6413
Misses 37 37
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
rluders
approved these changes
Apr 5, 2023
rluders
requested changes
Apr 5, 2023
There was a problem hiding this comment.
@meesvandongen thanks for the update. I guess that you removed the separator.
It should look similar to this:
https://flowbite.com/docs/components/list-group/
Can you fix it? Otherwise, it looks great.
|
@rluders good catch, didn't see it. Fixed. |
rluders
approved these changes
Apr 6, 2023
SrivatsaRUpadhya
added a commit
to SrivatsaRUpadhya/flowbite-react
that referenced
this pull request
Apr 13, 2023
* fix: group list styling * fix: borders between list group items --------- Co-authored-by: Mees van Dongen <[email protected]> Co-authored-by: Ricardo Lüders <[email protected]>
10 tasks
rluders
added a commit
to SrivatsaRUpadhya/flowbite-react
that referenced
this pull request
Apr 17, 2023
* fix: group list styling * fix: borders between list group items --------- Co-authored-by: Mees van Dongen <[email protected]> Co-authored-by: Ricardo Lüders <[email protected]>
rluders
added a commit
that referenced
this pull request
Apr 17, 2023
…ss == 0 (#698) * fix: group list styling (#668) * fix: group list styling * fix: borders between list group items --------- Co-authored-by: Mees van Dongen <[email protected]> Co-authored-by: Ricardo Lüders <[email protected]> * fix(progress.tsx): progress bar shows labels even when it is disabled at progress value is 0 The conditional rendring using the '&&' would return 0 on condition being false which would get displayed when progress value is 0. This was fixed using ternary operator instead. And also the label would get hidden at low progress values which is now fixed. fix #696 * style(default.ts): changed progress bar label(inside label) color for light mode * fix(components/progressbar): fix progressbar showing label when progress == 0 --------- Co-authored-by: Mees van Dongen <[email protected]> Co-authored-by: Ricardo Lüders <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes
While keeping the
<ul><li>elements in-tact.Also see https://flowbite-react.com/list-group
After
Type of change
How Has This Been Tested?
N/A
Checklist: