Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(button): fixes outline button #654

Merged
merged 1 commit into from
Mar 5, 2023

Conversation

rluders
Copy link
Collaborator

@rluders rluders commented Mar 5, 2023

Description

By using this code:

<Button fullSized={true} outline={true}>
  Acessar
  <HiArrowRight className="w-5 h-5 ml-2" />
</Button>

It caused this error:
image

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Breaking changes

No

How Has This Been Tested?

  • Manual test
  • Unit test still working

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@rluders rluders requested a review from tulup-conner March 5, 2023 11:33
@codecov
Copy link

codecov bot commented Mar 5, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change

Comparison is base (8fd9ddc) 99.42% compared to head (24aa9ea) 99.42%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #654   +/-   ##
=======================================
  Coverage   99.42%   99.42%           
=======================================
  Files         130      130           
  Lines        6413     6413           
  Branches      477      477           
=======================================
  Hits         6376     6376           
  Misses         37       37           
Impacted Files Coverage Δ
src/lib/theme/default.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@rluders rluders marked this pull request as draft March 5, 2023 11:39
@rluders rluders force-pushed the fix/button-outline branch from 0f81ead to 24aa9ea Compare March 5, 2023 13:50
@rluders rluders marked this pull request as ready for review March 5, 2023 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants