fix(themecontext): fixing ReferenceError: window is not defined error with Next.js
#652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r with Next.js The variable `userPreferenceIsDark` was initialized with a value from the window object. This was causing an error with Next because of SSR. I added the check of the window, if it's on the server side, set to white
…or with Next.js The variable`userPreferenceIsDark` was initialized with a value from the window object. This was causing an error with Next because of SSR. I added the check of the window, if it's on the server side the value is set to `false`
… userPreferenceIsDark_error # Conflicts: # src/lib/components/Flowbite/ThemeContext.tsx
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #652 +/- ##
=======================================
Coverage 99.42% 99.42%
=======================================
Files 130 130
Lines 6413 6413
Branches 477 477
=======================================
Hits 6376 6376
Misses 37 37
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The variable
userPreferenceIsDarkwas initialized with a value from the window object. This was causing an error with Next because of SSR. I added the check of the window, if it's on the server side the value is set tofalseType of change
Please delete options that are not relevant.
How Has This Been Tested?
On my Next.js project that was causing the error.
Checklist: