feat(/lib/theme): add Tailwind CSS colors to <Alert>s
#586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ert component (issue themesberg#473) themesberg#473 re themesberg#473
…te dark add "gray" and "light" to add support to all FlowbiteColors re themesberg#473
linter
brenoliradev
changed the title
Codecov ReportBase: 99.31% // Head: 99.31% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #586 +/- ##
=======================================
Coverage 99.31% 99.31%
=======================================
Files 131 131
Lines 6387 6412 +25
Branches 477 477
=======================================
+ Hits 6343 6368 +25
Misses 44 44
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
rluders
requested changes
Feb 14, 2023
…o just FlowbiteColors Since AlertColors now implement all colors from FlowbiteColors I had replaced it
11 tasks
tulup-conner
requested changes
Feb 21, 2023
tulup-conner
changed the title
<Alert>s
This was a mistake I made while merging their PR manually.
|
I can't merge this without a re-review from you @rluders |
tulup-conner
approved these changes
Feb 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
(It's my first PR here lol. Looking forward to fix things if needed. :))
This change starts adding all colors to components in Flowbite. I'll be partially updating the components until I got every of then with all colors from FlowbiteColors avaliable.
Fixes # 473 (partially)
Type of change
How Has This Been Tested?
Since it was a visual change I used the Storybook to validate if colors are changing as expected.
Checklist: