fix(progressbar): fix unclear label usage (#468)

[revnandi]

Description

Added separate props to display/hide Progressbar progress percentage and label, also the ability to position these labels inside/outside separately.

Fixes #468

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change contains documentation update

Breaking changes

"label" prop renamed to textLabel

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

• Unit test for the conditional rendering of labels

Test Configuration:

N/A

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• Any dependent changes have been merged and published in downstream modules
• I have checked my code and corrected any misspellings

[rluders]

@revnandi correct me if I'm wrong, but this PR fixes #468. Right?

[revnandi]

Yes correct

[codecov]

Codecov Report

Patch coverage: 100.00% and no project coverage change

Comparison is base (959b88b) 99.42% compared to head (47f9949) 99.42%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #547   +/-   ##
=======================================
  Coverage   99.42%   99.42%           
=======================================
  Files         130      130           
  Lines        6414     6428   +14     
  Branches      477      481    +4     
=======================================
+ Hits         6377     6391   +14     
  Misses         37       37           

Impacted Files	Coverage Δ
src/lib/components/Progress/Progress.tsx	100.00% <100.00%> (ø)
src/lib/theme/default.ts	100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[rluders]

I guess that just need to include some unit tests to cover the scenario, and it should be good to merge.

[rluders]

It looks good, just need to run the prettier to fix some code style issues.

[revnandi]

It looks good, just need to run the prettier to fix some code style issues.

Thanks, the formatting has ben fixed

[rluders]

@revnandi it seems that there is one piece of code that was introduced and wasn't tested. Could you provide some unit test for it?

[revnandi]

@revnandi it seems that there is one piece of code that was introduced and wasn't tested. Could you provide some unit test for it?

should be 100% now

[tulup-conner]

Thank you for this~!

Resolved