Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(accordion): add collapseAll prop (#515) #524

Merged
merged 1 commit into from
Jan 11, 2023

Conversation

mortezasabihi
Copy link
Contributor

Description

Added collapseAll prop to resolve #515

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change contains documentation update

Breaking changes

Please document the breaking changes if suitable.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • Firmware version:
  • Hardware:
  • Toolchain:
  • SDK:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@rluders
Copy link
Collaborator

rluders commented Jan 11, 2023

And this was a very quick PR. o_O

@rluders rluders self-requested a review January 11, 2023 12:42
@codecov
Copy link

codecov bot commented Jan 11, 2023

Codecov Report

Base: 98.96% // Head: 98.96% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (1a12086) compared to base (ec97d23).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #524   +/-   ##
=======================================
  Coverage   98.96%   98.96%           
=======================================
  Files         127      127           
  Lines        5528     5530    +2     
  Branches      465      466    +1     
=======================================
+ Hits         5471     5473    +2     
  Misses         57       57           
Impacted Files Coverage Δ
src/lib/components/Accordion/Accordion.tsx 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@rluders rluders added this to the 0.4.0 milestone Jan 11, 2023
@rluders rluders merged commit d2206b5 into themesberg:main Jan 11, 2023
@strollhy
Copy link

Yay! Thanks for adding this 💯 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow all Accordion Panels to be collapsed by default
4 participants