Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(modal): clear modal container ref on unmount #514

Merged
merged 2 commits into from
Jan 5, 2023

Conversation

myabeaver
Copy link
Contributor

Description

This clears the modal container ref introduced here: #495

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@codecov
Copy link

codecov bot commented Jan 3, 2023

Codecov Report

Base: 97.45% // Head: 97.46% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (73623c2) compared to base (a71573c).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #514   +/-   ##
=======================================
  Coverage   97.45%   97.46%           
=======================================
  Files         127      127           
  Lines        5505     5518   +13     
  Branches      441      443    +2     
=======================================
+ Hits         5365     5378   +13     
  Misses        140      140           
Impacted Files Coverage Δ
src/lib/components/Modal/Modal.tsx 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@myabeaver myabeaver force-pushed the clear-modal-container-ref branch from c258f6f to 7e87696 Compare January 3, 2023 09:34
Only for codecov
@myabeaver
Copy link
Contributor Author

Changed lines of code for codecov to not report.

@rluders rluders added this to the 0.4.0 milestone Jan 5, 2023
@rluders rluders merged commit 3387128 into themesberg:main Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants