Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(classname): all components with classname access #405

Merged
merged 1 commit into from
Oct 22, 2022

Conversation

rluders
Copy link
Collaborator

@rluders rluders commented Oct 22, 2022

Description

All components with className access.

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Breaking changes

N/A

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Unit test
  • Manual test

Test Configuration:

N/A

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@codecov
Copy link

codecov bot commented Oct 22, 2022

Codecov Report

Base: 98.48% // Head: 98.47% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (f03c705) compared to base (1027212).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #405      +/-   ##
==========================================
- Coverage   98.48%   98.47%   -0.02%     
==========================================
  Files         103      102       -1     
  Lines        4293     4264      -29     
  Branches      390      388       -2     
==========================================
- Hits         4228     4199      -29     
  Misses         65       65              
Impacted Files Coverage Δ
src/lib/components/Accordion/Accordion.tsx 100.00% <100.00%> (ø)
src/lib/components/Accordion/AccordionContent.tsx 100.00% <100.00%> (ø)
src/lib/components/Accordion/AccordionTitle.tsx 100.00% <100.00%> (ø)
src/lib/components/Button/Button.tsx 100.00% <100.00%> (ø)
src/lib/components/Card/Card.tsx 100.00% <100.00%> (ø)
src/lib/components/Dropdown/Dropdown.tsx 97.72% <100.00%> (-0.02%) ⬇️
src/lib/components/ListGroup/ListGroup.tsx 100.00% <100.00%> (ø)
src/lib/components/ListGroup/ListGroupItem.tsx 100.00% <100.00%> (ø)
src/lib/components/Rating/Rating.tsx 100.00% <100.00%> (ø)
src/lib/components/Sidebar/Sidebar.tsx 100.00% <100.00%> (ø)
... and 7 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@rluders rluders merged commit 99b4ceb into themesberg:main Oct 22, 2022
@rluders rluders deleted the missing-classname-components branch October 22, 2022 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant