Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(component): theme support to pagination #195

Merged
merged 3 commits into from
Jun 5, 2022

Conversation

rluders
Copy link
Collaborator

@rluders rluders commented Jun 5, 2022

Breaking changes

Pagination can be customized using

pagination: {
    base: string;
    layout: {
      table: {
        base: string;
        span: string;
      };
    };
    pages: {
      base: string;
      showIcon: string;
      previous: {
        base: string;
        icon: string;
      };
      next: {
        base: string;
        icon: string;
      };
      selector: {
        base: string;
        active: string;
      };
    };
  };

closes #140

@rluders rluders requested a review from tulup-conner June 5, 2022 12:27
src/lib/components/Pagination/index.tsx Outdated Show resolved Hide resolved
src/lib/components/Pagination/index.tsx Outdated Show resolved Hide resolved
src/lib/components/Pagination/index.tsx Outdated Show resolved Hide resolved
src/lib/components/Pagination/index.tsx Outdated Show resolved Hide resolved
src/lib/components/Pagination/index.tsx Outdated Show resolved Hide resolved
@rluders rluders requested a review from tulup-conner June 5, 2022 12:46
@tulup-conner
Copy link
Collaborator

Sorry, I meant that the ="true" is redundant in aria-hidden="true" not that the attribute should be removed @rluders

@rluders rluders force-pushed the theme-pagination-component branch from 7fe9f4e to 191744a Compare June 5, 2022 13:29
@rluders rluders requested a review from tulup-conner June 5, 2022 13:30
@rluders
Copy link
Collaborator Author

rluders commented Jun 5, 2022

Sorry, I meant that the ="true" is redundant in aria-hidden="true" not that the attribute should be removed @rluders

could you please check it again?

@rluders rluders merged commit 80b7e2a into themesberg:main Jun 5, 2022
@rluders rluders deleted the theme-pagination-component branch June 5, 2022 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Theme: Pagination component
2 participants