fix(ButtonGroup): dynamic generated button with group wasn't styled properly #1273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1273 +/- ##
==========================================
- Coverage 99.54% 97.29% -2.26%
==========================================
Files 163 216 +53
Lines 6621 9245 +2624
Branches 401 542 +141
==========================================
+ Hits 6591 8995 +2404
- Misses 30 250 +220 ☔ View full report in Codecov by Sentry. |
|
@SutuSebastian - please have a look & review the fix of the bug mentioned in Issue #1269 . |
SutuSebastian
changed the title
|
Hello @SutuSebastian , Sorry to bother you, but can you please review this PR? |
SutuSebastian
approved these changes
Mar 12, 2024
…t styled properly Dynamically generated buttons within a button group are not properly styled. themesberg#1269 fix themesberg#1269
SutuSebastian
force-pushed
the
fix/button-group-dynamic
branch
from
33ae831 to
9d328a5
Compare
Yeah!. Let's find a proper solution for it |
|
@SutuSebastian - this codecov issue again |
chunkerchunker
added a commit
to chunkerchunker/flowbite-react
that referenced
this pull request
Mar 28, 2024
This change fixes the following issue: ButtonGroup was adding positionInGroup to all children rather than just Buttons. For example, in the following, both the Buttons and the child spans get positionInGroup props: ``` <Button.Group><Button><span>b1</span></Button><Button><span>b2</span></Button></Button.Group> ``` This results in a React warning: “Warning: React does not recognize the `positionInGroup` prop on a DOM element...” The review comment in the original code change causing this hints at this issue as well: themesberg#1273 (comment)
Suggested fix in #1323 |
SutuSebastian
pushed a commit
to chunkerchunker/flowbite-react
that referenced
this pull request
Mar 29, 2024
This change fixes the following issue: ButtonGroup was adding positionInGroup to all children rather than just Buttons. For example, in the following, both the Buttons and the child spans get positionInGroup props: ``` <Button.Group><Button><span>b1</span></Button><Button><span>b2</span></Button></Button.Group> ``` This results in a React warning: “Warning: React does not recognize the `positionInGroup` prop on a DOM element...” The review comment in the original code change causing this hints at this issue as well: themesberg#1273 (comment)
Merged
SutuSebastian
pushed a commit
to chunkerchunker/flowbite-react
that referenced
this pull request
Mar 29, 2024
This change fixes the following issue: ButtonGroup was adding positionInGroup to all children rather than just Buttons. For example, in the following, both the Buttons and the child spans get positionInGroup props: ``` <Button.Group><Button><span>b1</span></Button><Button><span>b2</span></Button></Button.Group> ``` This results in a React warning: “Warning: React does not recognize the `positionInGroup` prop on a DOM element...” The review comment in the original code change causing this hints at this issue as well: themesberg#1273 (comment)
This was referenced May 21, 2024
SutuSebastian
pushed a commit
that referenced
this pull request
Jun 19, 2024
* Fix React warning in ButtonGroup This change fixes the following issue: ButtonGroup was adding positionInGroup to all children rather than just Buttons. For example, in the following, both the Buttons and the child spans get positionInGroup props: ``` <Button.Group><Button><span>b1</span></Button><Button><span>b2</span></Button></Button.Group> ``` This results in a React warning: “Warning: React does not recognize the `positionInGroup` prop on a DOM element...” The review comment in the original code change causing this hints at this issue as well: #1273 (comment) * fix formatting
starmaksym
pushed a commit
to starmaksym/flowbite-react
that referenced
this pull request
Jan 4, 2025
* Fix React warning in ButtonGroup This change fixes the following issue: ButtonGroup was adding positionInGroup to all children rather than just Buttons. For example, in the following, both the Buttons and the child spans get positionInGroup props: ``` <Button.Group><Button><span>b1</span></Button><Button><span>b2</span></Button></Button.Group> ``` This results in a React warning: “Warning: React does not recognize the `positionInGroup` prop on a DOM element...” The review comment in the original code change causing this hints at this issue as well: themesberg/flowbite-react#1273 (comment) * fix formatting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dynamically generated buttons within a button group are not properly styled.
fix #1269