Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

About Tinysou and Gitment #562

Closed
3 tasks done
stevenjoezhang opened this issue Jan 3, 2019 · 1 comment · Fixed by #565
Closed
3 tasks done

About Tinysou and Gitment #562

stevenjoezhang opened this issue Jan 3, 2019 · 1 comment · Fixed by #565

Comments

@stevenjoezhang
Copy link
Contributor

stevenjoezhang commented Jan 3, 2019

I agree and want to create new issue


Seems Tinysou was deprecated in 2016, and it's never introduced in _config.yml, see: iissnan/hexo-theme-next@3afb544
Should we remove
layout/_third-party/search/tinysou.swig
layout/_partials/search/tinysou.swig

and modify
layout/_third-party/search/index.swig
layout/_partials/search/index.swig
layout/_partials/header/menu.swig

To remove it completely?

Besides, Gitment is outdated too: imsun/gitment#170
https://github.com/imsun/gitment#why-does-gitment-send-a-request-to-gh-oauthimsunnet

@ivan-nginx
Copy link
Member

IDK about Chinese services too much. It's on your decision, guys.

@stevenjoezhang stevenjoezhang changed the title About tinysou About Tinysou and Gitment Jan 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants