Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop swig dependency [solved] #33

Closed
charsi opened this issue Jan 13, 2018 · 4 comments
Closed

Drop swig dependency [solved] #33

charsi opened this issue Jan 13, 2018 · 4 comments
Labels
Solved Template Engine

Comments

@charsi
Copy link

charsi commented Jan 13, 2018 •
edited by ivan-nginx
Loading

Hexo is switching to nunjucks from swig as it seems to be unmaintained now. There is some discussion on backward compatibility and one of their concerns is ensuring this theme keeps working as expected.

So perhaps a future release of this theme can make the switch too and make things easier for everyone? hexojs/hexo#2903
@ivan-nginx
Copy link
Member

ivan-nginx commented Jan 13, 2018 •
edited
Loading

Don't worry about this. I already connected with @NoahDragon about possible swig changes in last year and he told me what NexT will work regardless of Hexo. So, only not maintained engine (swig) may have a problem (but he did not) and i, if will so hard, can switch from swig on something like mustache. Don't worry about this and i don't want to inside in this Hexo discussion: there are their own decision, my part of work only is NexT.

@Blealtan
Copy link

Upvote for dropping this deprecated dependency (as said by npm) . Hope we can put this on the "future" timeline.

@ivan-nginx ivan-nginx mentioned this issue Jan 22, 2018
Closed
72 tasks
@ivan-nginx
Copy link
Member

ivan-nginx commented Mar 15, 2018 •
edited
Loading

Already replaced swig by swig-templates in this pull and released in Hexo v3.5.0 and tested with NexT v6.

So, no need to worry about dropped swig anymore.

@ivan-nginx ivan-nginx changed the title Drop swig dependency Drop swig dependency [replaced swig by swig-templates in Hexo 3.5.0] Mar 15, 2018
@ivan-nginx ivan-nginx changed the title Drop swig dependency [replaced swig by swig-templates in Hexo 3.5.0] Drop swig dependency [solved] Mar 4, 2019
@theme-next theme-next locked as resolved and limited conversation to collaborators Apr 1, 2019
@stevenjoezhang
Copy link
Contributor

See also #1214

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Solved Template Engine
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@charsi @Blealtan @stevenjoezhang @ivan-nginx