-
Notifications
You must be signed in to change notification settings - Fork 703
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add label to network list search input #4887
Conversation
resolves thelounge#4863 resolves thelounge#4864
@@ -22,7 +22,7 @@ | |||
:data-name="channel.name" | |||
:data-type="channel.type" | |||
:aria-controls="'#chan-' + channel.id" | |||
:aria-selected="active" | |||
:aria-selected="true" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Drive-by fix here. active
is not a valid value. Valid values are: true
, false
, or undefined (blank)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NACK, active is a prop, passed via the element by vue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah right. I'm new to Vue and I missed that this was a dynamic attribute. I'll revert this change shortly.
@keypress.enter.exact.prevent="onSubmit" | ||
@blur="onBlur" | ||
/> | ||
<label :aria-label="getInputPlaceholder(channel)"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added parent label
and moved aria-label
to it, same as below.
Can you explain to me how this fixes #4863? As for #4864 this has the aria-label already on there as well, normal users don't need a label as the placeholder text serves the same purpose, so what's the rational for doing it? |
One distinction is that the It might not cover all cases and there's a fallback such as wrapping the What's currently in the source of these corresponding changes currently meets WCAG 2.1 AA guidelines, so I think I'll close this PR. |
|
Closing out for now! Thanks for the review @brunnre8 |
resolves #4863
resolves #4864