Fix image viewer cycling when some previews are hidden #1367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astorije
added
the
Type: Bug
xPaw
approved these changes
Jul 24, 2017
matburnham
pushed a commit
to matburnham/lounge
that referenced
this pull request
Sep 6, 2017
…cycle Fix image viewer cycling when some previews are hidden
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To reproduce the bug, on
master:➡️ The < (Previous image) button does not show up.
Same applies for > (Next image), obviously.
Issue was that the first check (the one for previews on the same message) was only checking for existing previews, not if they were being expanded. So in the scenario above, first check would detect one preview, but the class was never added (as it gets added only when preview is shown), so the cycling button is not shown.