Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix link previews not truncating correctly #1363

Merged
merged 1 commit into from
Jul 24, 2017
Merged

Fix link previews not truncating correctly #1363

merged 1 commit into from
Jul 24, 2017

Conversation

xPaw
Copy link
Member

@xPaw xPaw commented Jul 22, 2017

@xPaw xPaw added the Type: Bug Issues that report and PRs that solve any defects that cause unexpected behaviors. label Jul 22, 2017
@xPaw xPaw added this to the 2.4.0 milestone Jul 22, 2017
@xPaw xPaw requested a review from astorije July 22, 2017 09:14
@xPaw xPaw force-pushed the xpaw/fix-preview-overflow branch from 5b6c914 to 52d8555 Compare July 22, 2017 09:34
astorije
astorije approved these changes Jul 24, 2017
View reviewed changes
Copy link
Member

@astorije astorije left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just had that issue locally. That is a very messed up solution, but that's a fix! Good catch!

@astorije astorije merged commit dc33b3e into master Jul 24, 2017
@astorije astorije deleted the xpaw/fix-preview-overflow branch July 24, 2017 05:47
matburnham pushed a commit to matburnham/lounge that referenced this pull request Sep 6, 2017
@astorije
Merge pull request thelounge#1363 from thelounge/xpaw/fix-preview-ove…
1bb73bc 
…rflow

Fix link previews not truncating correctly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@astorije astorije astorije approved these changes

Assignees
No one assigned
Labels
Type: Bug Issues that report and PRs that solve any defects that cause unexpected behaviors.
Projects
None yet
Milestone
2.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@xPaw @astorije