Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix jumps when toggling link preview #1298

Merged
merged 1 commit into from
Jul 4, 2017
Merged

Fix jumps when toggling link preview #1298

merged 1 commit into from
Jul 4, 2017

Conversation

xPaw
Copy link
Member

@xPaw xPaw commented Jul 4, 2017 •
edited
Loading

.chat is the actual container that overflows, not .messages.

@xPaw xPaw added the Type: Bug Issues that report and PRs that solve any defects that cause unexpected behaviors. label Jul 4, 2017
@xPaw xPaw added this to the 2.3.3 milestone Jul 4, 2017
astorije
astorije approved these changes Jul 4, 2017
View reviewed changes
Copy link
Member

@astorije astorije left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing this, it works. Not sure why this is the fix though, worth adding a description to the PR post-merge.

@xPaw xPaw merged commit fc231bc into master Jul 4, 2017
@xPaw xPaw deleted the xpaw/fix-toggle-scroll branch July 4, 2017 18:00
matburnham pushed a commit to matburnham/lounge that referenced this pull request Sep 6, 2017
@xPaw
Merge pull request thelounge#1298 from thelounge/xpaw/fix-toggle-scroll
08564d2 
Fix jumps when toggling link preview
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@astorije astorije astorije approved these changes

Assignees
No one assigned
Labels
Type: Bug Issues that report and PRs that solve any defects that cause unexpected behaviors.
Projects
None yet
Milestone
2.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@xPaw @astorije