Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix background color contrast on Zenburn previews #1297

Merged
merged 1 commit into from
Jul 4, 2017

Conversation

astorije
Copy link
Member

@astorije astorije commented Jul 4, 2017

Again, since we're fixing previews for 2.3.3, here is another one, that fixes an accessibility issue.

Before After
screen shot 2017-07-04 at 13 23 35 screen shot 2017-07-04 at 13 22 59

@astorije astorije added the Type: Bug Issues that report and PRs that solve any defects that cause unexpected behaviors. label Jul 4, 2017
@astorije astorije added this to the 2.3.3 milestone Jul 4, 2017
@astorije astorije requested a review from xPaw July 4, 2017 17:41
@@ -59,7 +59,7 @@ body {
}

#footer {
background: #33332f;
background: #333;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty sure this was a typo, because this is 1 digit off, so probably a CtrlDown in a text editor or something.

Junction between footer and input margin, before:

screen shot 2017-07-04 at 13 37 25

@astorije astorije merged commit c7ed85a into master Jul 4, 2017
@astorije astorije deleted the astorije/color-previews-zenburn branch July 4, 2017 17:49
matburnham pushed a commit to matburnham/lounge that referenced this pull request Sep 6, 2017
…ews-zenburn

Fix background color contrast on Zenburn previews
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issues that report and PRs that solve any defects that cause unexpected behaviors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants