Do not truncate link previews if viewport can fit more text #1293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xPaw
added
the
Type: Bug
|
You had me super excited, but unfortunately it doesn't work correctly when reaching the end of the screen :(
^ No ellipsis + text on second line instead of next to thumbnail. |
|
Damn it. |
xPaw
force-pushed
the
xpaw/fix-preview-truncate
branch
2 times, most recently
from
635d934
to
ff6b22d
Compare
|
@astorije fixed with flexbox. |
astorije
requested changes
Jul 4, 2017
client/css/style.css
Outdated
| @@ -1129,15 +1129,21 @@ kbd { | |||
| } | |||
|
|
|||
| #chat .toggle-content .thumb { | |||
| float: left; | |||
| display: flex; | |||
There was a problem hiding this comment.
I meant, this would only apply to its children, which .thumb doesn't have any, no?
client/views/msg_preview.tpl
Outdated
| @@ -8,11 +8,15 @@ | |||
| {{else}} | |||
| {{#if thumb}} | |||
| <img src="{{thumb}}" class="thumb"> | |||
| <div class="toggle-text"> | |||
There was a problem hiding this comment.
Probably worth rendering this div whether or not the thumb appears for consistency sake.
xPaw
force-pushed
the
xpaw/fix-preview-truncate
branch
from
ff6b22d
to
40bd949
Compare
xPaw
force-pushed
the
xpaw/fix-preview-truncate
branch
from
40bd949
to
c62bc2f
Compare
astorije
approved these changes
Jul 4, 2017
matburnham
pushed a commit
to matburnham/lounge
that referenced
this pull request
Sep 6, 2017
…ncate Do not truncate link previews if viewport can fit more text
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1084.
float: lefton the thumbnail image pushed text, but did not increase container width.Before:
After:
