More transition effects #1117
More transition effects #1117
Conversation
xPaw
added
the
Type: Feature
bews
force-pushed
the
bews/dev-3-transitions
branch
from
a420008 to
e65e97a
Compare
bews
force-pushed
the
bews/dev-3-transitions
branch
from
e65e97a to
bbb06f8
Compare
| -webkit-animation-delay: .4s; | ||
| animation-delay: .4s; | ||
| -webkit-animation-delay: .1s; | ||
| animation-delay: .1s; |
There was a problem hiding this comment.
Could you revert this please? We actually re-added the animation delay some time ago on purpose to avoid fidgeting on timestamps. We'd be better off with default values.
There was a problem hiding this comment.
As I mentioned before, it was done to match new transition effects. There are cases when these 2 animations happen simultaneously (settings, help, toggle user list, etc) , and having different animation duration makes them look bad.
There was a problem hiding this comment.
Yes, I read your PR description 😅
However, your changes are not on an animation duration but on an animation delay. There is a reason we have a 0.4s delay on tooltips, it's to avoid the flickering when moving the mouse over by chance.
We need to keep this at .4s and I won't be able to 👍 until they're reverted. Would you mind doing so? 😃
There was a problem hiding this comment.
We can keep .4 for timestamps only.
There was a problem hiding this comment.
No, we cannot 😅
We would really appreciate if you fix this so we can 👍 and merge this. Thanks! :)
There was a problem hiding this comment.
No, we cannot
Why?
if you fix this
You're asking to break this, not fix.
There was a problem hiding this comment.
Why?
To keep all our tooltips consistent, and this is not negotiable 😅
You're asking to break this, not fix.
Sigh
No, I'm not. How is keeping reasonable tooltip delays (again, not animation durations) breaking anything?
I may very well be missing something, but please explain me why it is needed to reduce the tooltip apparition delay? I honestly have no idea how the animation delay could collide with any other animation out there, but if it did, .1s would be more subject to do that than .4s.
Anyway, I really don't think there is anything to break here, so unless I'm missing something obvious, please change them back.
There was a problem hiding this comment.
Yes, and again there are good reasons why we added a delay.
Anyway, I feel like we are going in circles here. This is my final review for this PR: please revert the animation delay change and you should get my 👍. Thanks!
| color: #333; | ||
| margin-top: 6px; | ||
| margin-bottom: 6px; |
There was a problem hiding this comment.
Actually, this has a tiny issue, in which it adds extra margin around elements within the same "group":
| Before your PR | After your PR |
|---|---|
 |
 |
Mind fixing this please?
There was a problem hiding this comment.
Um.. I didn't expect any groups here. This can be fixed only by returning to the old design. Are those groups a planned feature or I'm missing smth?
There was a problem hiding this comment.
Correct, the separator (divider in our HTML) is not meant to be present between all rows. The nearest and easiest addition to these dropdowns I can think of is having multiple user actions: kick, ban, etc. So rows would be: nick / divider / ban / kick / ...
|
@bews, are you okay reverting the animation delay change as requested in the review? This PR is simple and 🎉 outside of that minor change needed, it should make it to |
No, I'm not, it's a crucial thing here. Also, this PR is incomplete without #1130 (since I removed some parts from here), therefore it's not ready anymore. Anyway, it might be better to leave these things to themes, so I close this. |
|
That's frustrating, it was almost perfect (and some more time wasted...). |
|
I wasted more time on these PRs than you, so things are not so bad 😸 |
|
The Good Parts of this has been ported to #1314. It literally took me 2 minutes :) |
This adds transition effects for almost every element with hover support.
Also transition + hover effects were added to a lot of buttons:
In this menu background change covers the whole block now:
Tooltipped animation-delay was decreased 0.4 -> 0.1 to match new transition effects.
TODO: