Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prompting for country on first run #16

Closed
mrchrisadams opened this issue Jun 15, 2022 · 2 comments
Closed

Prompting for country on first run #16

mrchrisadams opened this issue Jun 15, 2022 · 2 comments

Comments

@mrchrisadams
Copy link
Member

After using the new CLI, I've realised that lots of us might have a locale like the US even if we live somewhere else (this was my experience the first time when testing it in Berlin).

If you know your country code you can still pass in the cli flag so it's not a massive problem, but it did catch me out.

Anyway - if we already get some kind of support of config files from the suite of CLI tools we use, it might be worth prompting for a given country on the first run, and then writing this to something like ~/.config/grid-intensity.

Not a priority, but would be nice.

@rossf7
Copy link
Contributor

rossf7 commented Jun 15, 2022

Good point and I can see lots of situations when the locale won't match. Right now I'm in the UK but my locale is set to ES 😄

We could prompt the user on first run. Maybe still defaulting it from the locale but letting the user change it? Persisting this to a config file would be useful and can be done with the viper library.

https://github.com/spf13/viper

@rossf7
Copy link
Contributor

rossf7 commented Jul 15, 2022

This shipped in the 0.3.0 release

@rossf7 rossf7 closed this as completed Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants