Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document different ways to calculate per domain calculations and how this changes figures #183

Closed
mrchrisadams opened this issue Dec 21, 2023 · 3 comments
Assignees
Labels
documentation Improvements or additions to documentation help wanted Extra attention is needed

Comments

@mrchrisadams
Copy link
Member

mrchrisadams commented Dec 21, 2023

This is a follow on issue from #182, where removing page Xray specific functions means we non longer have an implicit 'recommended' way to tally up emissions per domain.

This may be a decision you delegate to specific models like how SWD has specific implementations of a public methods, like perbyteTrace():

https://developers.thegreenwebfoundation.org/co2js/methods/#perbytetrace-sustainable-web-design-only

Either way, being more explicit at least would help make it clearer why some values are different to others across calculators when using the same code.

@mrchrisadams mrchrisadams added documentation Improvements or additions to documentation help wanted Extra attention is needed labels Dec 21, 2023
@fershad
Copy link
Contributor

fershad commented Dec 30, 2023

@mrchrisadams this should be a pretty easy write up for the docs, although I'm not sure off the top of my head what section of the site it would live in.

Will aim to get around to this late January/early Feb.

@fershad fershad modified the milestones: 0.15, 0.16 Dec 30, 2023
@fershad fershad self-assigned this Dec 30, 2023
@fershad fershad modified the milestones: 0.16, 0.15 Jan 29, 2024
@fershad fershad removed this from the 0.15 milestone Apr 24, 2024
@fershad
Copy link
Contributor

fershad commented Apr 24, 2024

I've removed this as a milestone for 0.15 as it shouldn't tie to a release.

@mrchrisadams I've created a card in our internal Trello board to track this, as I think it would be good as a technical post on our blog. Okay to close this & track progress in Trello instead?

@mrchrisadams
Copy link
Member Author

Hey @fershad - works for me. thanks for letting me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants