Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lighthouse improvements for Best Practices #49

Closed
1 of 2 tasks
thescientist13 opened this issue Apr 24, 2018 · 4 comments
Closed
1 of 2 tasks

Lighthouse improvements for Best Practices #49

thescientist13 opened this issue Apr 24, 2018 · 4 comments
Labels
enhancement New feature or request lighthouse

Comments

@thescientist13
Copy link
Member

thescientist13 commented Apr 24, 2018 •
edited
Loading

screen shot 2018-04-24 at 10 52 26 am

  1. noopener
  2. short_name (might leave this for the PWA ticket, tbh)
@thescientist13 thescientist13 added chore build stuff, deploy stuff, etc etc lighthouse enhancement New feature or request and removed chore build stuff, deploy stuff, etc etc labels Apr 24, 2018
@thescientist13
Copy link
Member Author

https://www.npmjs.com/package/gatsby-plugin-manifest

@thescientist13
Copy link
Member Author

thescientist13 commented Apr 24, 2018 •
edited
Loading

need to patch upstream library react-social-icons and get a new version out to npm

@thescientist13
Copy link
Member Author

thescientist13 commented Apr 24, 2018 •
edited
Loading

while awaiting react social icons, started playing around with app manifest. seems to be some interop issues with favicons plugin because they both generate manifests.
gatsbyjs/gatsby#4382

could try using gatsby-plugin-sharp to create the favicon

This was referenced May 4, 2018
Closed
Merged
@thescientist13
Copy link
Member Author

Thanks to resolving #51 , our Best Practices score is now 94%! 🎉
screen shot 2018-05-07 at 6 14 26 pm

Last item is really a PWA item, so it make sense to defer this task to #52 🤔

@thescientist13 thescientist13 mentioned this issue May 7, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request lighthouse
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@thescientist13