Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove `classes: [page-one] from default starter #913

Open
1 task done
Erin-Cecele opened this issue Mar 26, 2024 · 2 comments
Open
1 task done

Remove `classes: [page-one] from default starter #913

Erin-Cecele opened this issue Mar 26, 2024 · 2 comments
Assignees

Comments

@Erin-Cecele
Copy link
Collaborator

Before proceeding, check to make sure there isn’t an existing issue for this idea or a similar one.

  • I have searched the existing issues and determined this is a new proposal.

Proposed change

Remove page-one to prevent users from applying it incorrectly in their projects.

Potential Impact

Advanced users will now need to know to apply it so double check that documentation is sufficient. Advanced users will now need to know how to apply it, so double-check that documentation is sufficient.

Supporting Information

No response

@cbutcosk
Copy link
Collaborator

@geealbers @Erin-Cecele Unless I've misunderstood this issue should you also consider renaming page-one to something like page-pdf-number-reset? The class doesn't have a large footprint in the markup+css (though I'd want to triple-check) and wraps a very specific styling function, or so it seems.

@Erin-Cecele
Copy link
Collaborator Author

Thank you for this feedback @cbutcosk. I will take it to the rest of the team.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants