-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EPUB cover image and author information not displaying as expected #715
Comments
This should be in
but I think this is a common enough use-case when creating Epubs that I should update the CLI to look for it. |
Added the cover parsing for the next epub.js release, and fixed the |
@fchasen The creator is still not being added to the package.opf file correctly: <dc:creator>[object Object]</dc:creator> I assume it has something to do with the way the info is structured in the manifest.json we're feeding in? Can you advise? This is what we have in manifest.json now:
|
Thanks, for that snippet - epubjs-cli was looking for the wrong key. |
Awesome. Thanks for the quick response! |
Before proceeding, check to make sure there isn’t an existing issue for this bug.
Steps to reproduce
quire build
and thenquire epub
to create the EPUB filejava -jar path/to/epubcheck.jar patt/to/epubjs.epub
Actual behavior
We're including a static cover image and creator information in the
_epub/manifest.json
file, but neither are showing up where expected. For instance when opening the file in Apple Books a thumbnail of the cover should appear, but it's only a Apple's default background, the book title, and "Unknown Author". The snippet of the manifest is below. I believe the cover file path is correct, not sure if the structure/naming of the JSON itself doesn't match epub.js expectations.Expected behavior
I'd expect to see the cover image in in the e-book reader interface in various places, and the author to be listed.
Version numbers
quire-cli 1.0.0-rc.6
quire-11ty 1.0.0-rc.8
node 18.12.1
What browsers are you seeing the problem on?
No response
Relevant Terminal/Shell output
No response
Supporting Information
No response
The text was updated successfully, but these errors were encountered: