Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to be able to process shortcodes in captions and tables #33

Open
Erin-Cecele opened this issue Oct 26, 2022 · 5 comments
Open

Need to be able to process shortcodes in captions and tables #33

Erin-Cecele opened this issue Oct 26, 2022 · 5 comments
Labels
dev enhancement New feature or request

Comments

@Erin-Cecele
Copy link
Contributor

I noticed a number of pop-up citations in the captions of the figures.yaml

Screen Shot 2022-10-26 at 1 28 11 PM

@Erin-Cecele
Copy link
Contributor Author

Rachel makes the following suggestion:

Ah, ok. In that case, then I will cut the brackets and just make these abbreviated parenthetical citations, i.e. “(Thickett et al. 2007)” and “See Hackney 2016.” I can mark this and will do it first in the captions file.

I asked her to hold off on making changes to the captions file.

@geealbers
Copy link
Member

Removing the pop-ups altogether is a good back-up plan, but I think we actually want to be able to process shortcodes in these instances, so I'm planning on putting it on the list for Getty Digital

@geealbers
Copy link
Member

Also occurs in at least the abstract of paper 40; and one of the group figure captions in paper 46

@geealbers geealbers added the bug Something isn't working label Nov 4, 2022
@geealbers geealbers changed the title Pop up Citations in Captions Need to be able to process shortcodes in captions and tables Nov 4, 2022
@Erin-Cecele
Copy link
Contributor Author

Note: any pop-ups in figure images captions have had the brackets removed, so they just appear in parens.

@geealbers
Copy link
Member

In fbcabbe, I've gone ahead and removed the last of the double-bracketed citations that were in places we couldn't process as shortcodes: the table key in table 27.1; figures 20.3 and 20.5. Marking the issue as an enhancement in case we want to revisit these after getty digital has found a solution.

@geealbers geealbers added enhancement New feature or request dev and removed bug Something isn't working second-pages labels Apr 8, 2023
@geealbers geealbers added bug Something isn't working and removed enhancement New feature or request labels Jun 22, 2023
@geealbers geealbers added enhancement New feature or request and removed bug Something isn't working labels Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants