Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Auth on Microservice Template #185

Merged
merged 9 commits into from
Jan 23, 2023
Merged

Conversation

jbolda
Copy link
Contributor

@jbolda jbolda commented Jan 5, 2023

Motivation

The microservice template should use the logged in user's GitHub auth to create the repository as this better respects the permission system in place.

Approach

Adjusted the auth options to better expose GitHub, and wire up the template with it.

@changeset-bot
Copy link

changeset-bot bot commented Jan 5, 2023

⚠️ No Changeset found

Latest commit: 5920064

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@frontsidejack
Copy link
Member

frontsidejack commented Jan 5, 2023

📣 NOTIFICATION
You are receiving this message because we did not publish any packages.

Generated by @thefrontside/actions Frontside

Copy link
Member

@taras taras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

app-config.yaml Show resolved Hide resolved
app-config.yaml Show resolved Hide resolved
.github/workflows/deploy.yaml Outdated Show resolved Hide resolved
@jbolda jbolda force-pushed the github-auth-component-create branch from ed8412d to 5920064 Compare January 23, 2023 16:23
@jbolda jbolda merged commit 22cc4b8 into main Jan 23, 2023
@jbolda jbolda deleted the github-auth-component-create branch January 23, 2023 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants