customize the executable name and URL #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to standup the executable delivery mechanism, we just hard-coded everything to be local development values and a fixed version of the executable name. However, the entire point is that everyone gets their own internal developer platform that is unique to them. We want to be able to customize that experience and also have it work in production environments. This adds the `executableName`, and `appURL` parameter to `createRouter` where you can pass in the specific name that you want your binary package to have. It will then compile it as that executable, and adjust the install script using a nunjucks template.
|
|
📣 NOTIFICATION Generated by @thefrontside/actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In order to standup the executable delivery mechanism, we just hard-coded everything to be local development values and a fixed version of the executable name. However, the entire point is that everyone gets their own internal developer platform that is unique to them. We want to be able to customize that experience and also have it work in production environments.
approach
This adds the
executableName, andappURLparameter tocreateRouterwhere you can pass in the specific name that you want your binary package to have. It will then compile it as that executable, and create a uniqueinstall.shscript using a nunjucks template.